COIOS-812: Identify native redirect flow (v4) #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nauaros
changed the title
atmamont
reviewed
Nov 1, 2024
|
goergisn
previously approved these changes
Nov 14, 2024
goergisn
approved these changes
Jan 15, 2025
| let container = try decoder.container(keyedBy: CodingKeys.self) | ||
| self.url = try container.decode(URL.self, forKey: .url) | ||
| self.paymentData = try container.decodeIfPresent(String.self, forKey: .paymentData) | ||
| self.type = try container.decode(RedirectType.self, forKey: .type) |
There was a problem hiding this comment.
Same as v5 - is it guaranteed the backend - in all different setups - provides that value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This development enables us to differentiate between regular and native redirects. To handle cases where native redirects fail (indicated by
nativeRedirectDatabeingnil), it's essential to track the originating flow type of each redirect.Motivation
Native redirect flows can occasionally fail if
nativeRedirectDataisnilwithin the action object. Currently, we handle this by discarding the native redirect (checking ifnativeRedirectDatais nil), and defaulting to a "direct issuer flow" using a/detailscall.To avoid the additional steps of the "direct issuer flow," we can address this issue on the backend. By identifying the native redirect flow, we can still retrieve the native redirect result directly.
Release notes
Ticket
COIOS-812