-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 3rd party workflow actions with Github API to access labels and PR body #1924
Replace 3rd party workflow actions with Github API to access labels and PR body #1924
Conversation
${commentIdentifier} |
cbe4dec
to
abf81a2
Compare
✅ No changes detectedComparing Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay |
Quality Gate passedIssues Measures |
Summary
Problem
External PRs from forks do not have access to Github token so none of external actions could be run successfully.
Options
pull_request
topull_request_target
). Documentation says labels and comments are perfect cases for such expansion but thinking security first I decided do explore other options.Using Github API and removing 3rd party actions requiring Github token. Using Github javascript-like API to post comments.Solution
Option 1 was chosen as I didn't manage to get option 2 working, it failed for the "post comment" section.
Ticket
COIOS-000Manual tests
Test release notes
This is a changed text wrapped in XML tag