Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding travis_wait to mvn install #281

Closed
wants to merge 1 commit into from

Conversation

FanJups
Copy link

@FanJups FanJups commented Dec 23, 2019

Description
Why ?
Building such big APIs as Adyen APIs can take a lot of time. It's possible to get a time out.
Here , I got a time out due to generating javadoc.
Then, I decided to add travis_wait and it works pretty well.

Official docs : https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

Why ?
Building such big APIs as Adyen APIs   can take a lot of time.  It's possible to get a time out.
Here (4hwc/4HWCAutonomousCar@96c6396), I got a time out due to generating javadoc. Then, I decided to add travis_wait and it works pretty well.

Official docs : https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 24.144% when pulling f2293bd on FanJups:travis-wait into 10a89ec on Adyen:develop.

@rkewlani
Copy link
Contributor

Thanks @FanJups for the PR and suggestion.
We would like to know more details on this because we don't get timeout on this. We never got this issue and it is not reported by others as well. Can you please explain what all steps you are performing so that we can reproduce it at our end.
Thanks,
Rajni
Adyen

@FanJups
Copy link
Author

FanJups commented Dec 27, 2019

You're welcome @rkewlani , my PR is based on what I faced while generating Javadoc weeks ago. I thought it would be helpful to prevent such case.

@rikterbeek
Copy link
Contributor

Hi @FanJups,

Thanks for this in general it is indeed a good idea to do this with calls that take time to produce the output. @rkewlani more info here https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received We will discuss in the team if we see any negatives if not we will merge it.

Regards,
Rik
Adyen

@rikterbeek
Copy link
Contributor

Hi @FanJups,

Discussed in the team and the build should not take more then 10 minutes and if it does we want to optimize this to make it shorter as it is a lightweight repo. We are building the project always for releases and did not have any issues. Could you investigate on your end what is going wrong with the generating of Javadoc as this should be quicker.

Regards,
Rik
Adyen

@rkewlani rkewlani closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants