Client is not following adyen docs about psp reference

[artemijan]

Describe the bug
Currently adyen api library is not following this documentation https://docs.adyen.com/development-resources/response-handling#error-response-fields
psp reference should be taken form the body first and if it doesn't exist then we should check headers
here is a line that contains wrong behaviour

adyen-python-api-library/Adyen/client.py

Line 632 in 26c0cf2

psp = headers.get('pspReference', response.get('pspReference'))

To Reproduce
Steps to reproduce the behavior:

1. make payments request
2. check AdyenResponse object
3. check that psp is taken from headers instead of body

Expected behavior
Accordingly to the documentation it should be taken from the body first

[artemijan]

I've found few other places where psp is taken from headers instead of body, probably there is a need to create common method get_psp(response) to incapsulate this logic in

[jillingk]

@artemijan,

Thank you for letting us know! It seems indeed that we should really check the response first as there can be discrepancies between the returned pspRefs in the header and response. Note that this is only for valid requests, from what I found invalid requests always return the same pspRef in header and response.

Best, Jilling
Adyen

[artemijan]

@jillingk , I'm not sure about valid requests) The issue is about error responses. And I was able to reproduce it while receiving an error from adyen api.

[jillingk]

@artemijan,

Hmm I totally missed that sorry. I will do some more digging. Since I've only found examples of errors having the same pspRef in header and response, it would be good to have this matter set straight. Thanks again for letting us know!

Best, Jilling
Adyen