Release 5.1.0 #139
Merged
Release 5.1.0 #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add orders, orders cancel, payment methods balance endpoints * Fix pycodestyle * Add paymentmethods balance test and remove order from application info list * Correct test
AlexandrosMor
requested review from
Aleffio,
acampos1916,
cyattilakiss,
martinsrenato and
rikterbeek
as code owners
acampos1916
reviewed
Apr 19, 2021
Comment on lines
+110
to
+130
| def test_checkout_api_url_orders(self): | ||
| self.client.live_endpoint_prefix = None | ||
| url = self.adyen.client._determine_checkout_url("test", | ||
| "orders") | ||
| self.assertEqual(url, "https://checkout-test.adyen.com" | ||
| "/v67/orders") | ||
|
|
||
| def test_checkout_api_url_order_cancel(self): | ||
| self.client.live_endpoint_prefix = None | ||
| url = self.adyen.client._determine_checkout_url("test", | ||
| "ordersCancel") | ||
| self.assertEqual(url, "https://checkout-test.adyen.com" | ||
| "/v67/orders/cancel") | ||
|
|
||
| def test_checkout_api_url_order_payment_methods_balance(self): | ||
| self.client.live_endpoint_prefix = None | ||
| url = self.adyen.client._determine_checkout_url("test", | ||
| "paymentMethods" | ||
| "Balance") | ||
| self.assertEqual(url, "https://checkout-test.adyen.com""/v67/" | ||
| "paymentMethods/balance") |
There was a problem hiding this comment.
Will these test fail when we move to >v67? Is it possible to make the version variable?
There was a problem hiding this comment.
Yes and we update them every time. It is a good idea to make a variable for them indeed
acampos1916
approved these changes
Apr 19, 2021
peterojo
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#138 [PW-4046] Add Order API
#137 Add support for adjustAuthorisation verb (with a test)
Tested scenarios
Fixed issue: