Adding-Modification-Functionality-Checkout-Api #142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [PW-4392] Update README based on the new template (Adyen#140) * Update README based on the new template * Update the endpoints versions * Add the api versions in the description * Add the example with xapi key * Apply suggestions from code review Co-authored-by: Ángel Campos <angel.campos@adyen.com> * Update README.md Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com> Co-authored-by: Ángel Campos <angel.campos@adyen.com> Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com> * Adding cancels action * [PW-4392] Update README based on the new template (Adyen#140) * Update README based on the new template * Update the endpoints versions * Add the api versions in the description * Add the example with xapi key * Apply suggestions from code review Co-authored-by: Ángel Campos <angel.campos@adyen.com> * Update README.md Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com> Co-authored-by: Ángel Campos <angel.campos@adyen.com> Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com> * Adding cancels action * Adding modifications to checkout api Co-authored-by: Alexandros Moraitis <alexandros.moraitis@adyen.com> Co-authored-by: Ángel Campos <angel.campos@adyen.com> Co-authored-by: Alessio Zampatti <alessio.zampatti@adyen.com> Co-authored-by: Eric Laff <eric.laff@tier.app>
Co-authored-by: Eric Laff <eric.laff@tier.app>
eraserhead0705
requested review from
Aleffio,
AlexandrosMor,
acampos1916,
cyattilakiss,
martinsrenato and
rikterbeek
as code owners
acampos1916
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Thanks for this contribution @eraserhead0705. I've left a couple of comments. Please re-open the pull request to develop instead of master
| https://docs.adyen.com/developers/checkout/api-integration | ||
| service (str): This is the API service to be called. | ||
| action (str): The specific action of the API service to be called | ||
| path_param (str): This is used to pass the id or referenceID to the API sercie |
There was a problem hiding this comment.
Suggested change
| path_param (str): This is used to pass the id or referenceID to the API sercie | |
| path_param (str): This is used to pass the ID or referenceID to the API service |
There was a problem hiding this comment.
Will fix this and open a new PR to develop,
| [](https://travis-ci.org/Adyen/adyen-python-api-library) | ||
| [](https://coveralls.io/github/Adyen/adyen-python-api-library?branch=master) | ||
|
|
||
| # Adyen APIs Library for Python |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
Not sure but these changes are stale now. Will not include them when I reopen.
|
Closing the PR as it should point to develop instead of master. We can edit the base branch here but I think the contributor needs to double check that the commits apply correctly to develop. Thanks for the contribution! |
|
@acampos1916 Thanks so much for the comments! I will go ahead and fix the above accordingly and reopen the PR. Additionally I will not include the readme edits as those have been merged. 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem you’re solving:
The Adyen Python Library lacks support for the full Checkout API actions.
Capture
Refund
Reversals
Cancel/Technical Cancel
Our Team at Tier needs this functionality implemented in the Python library in order to fully integrate with our backend system.
Your approach to fixing the problem:
Implemented the above functionality by building on the current service/client in the code base. I added a new parameter to send a path parameter to the Adyen Api.
Any tests you wrote:
Each new action has two tests written, one success and one that mocks an error.
Additionally a test that checks for raise condition.
Note:
I included a commit with a updated README. This was from a Adyen dev .