Allow API versions override at client init #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a usecase where we need two Adyen clients using two different versions in the same code base. Overriding version using settings.xxx_VERSION does not allow us to use multiple API versions depending on our usecases. Adding the possibility to override the API versions in the Client constructor solves this issue
mgu
requested review from
Aleffio,
AlexandrosMor,
acampos1916,
cyattilakiss,
martinsrenato and
rikterbeek
as code owners
|
there was no test related to settings but I can add one if necessary |
|
should I close my PR ? |
|
Sorry for the unresponsiveness @mgu. What do you think of this suggestion @AlexandrosMor @Aleffio ? |
acampos1916
approved these changes
Sep 7, 2021
AlexandrosMor
approved these changes
Sep 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a usecase where we need two Adyen clients using two different
versions in the same code base.
Overriding version using
settings.API_xxx_VERSIONdoes not allow us to usemultiple API versions depending on our usecases.
Adding the possibility to override the API versions in the Client
constructor solves this issue
Tested scenarios
don't change
settings.API_xxx_VERSIONbut pass version using kwargs when instanciating Adyen objectFixed issue: