feat: add support for Terminal API support #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrialland
commented
Sep 22, 2021
| except ImportError: | ||
| from .BaseTest import BaseTest | ||
|
|
||
| VERSION = pkg_resources.get_distribution("Adyen").version |
There was a problem hiding this comment.
Not sure if I should use the version from the settings or the one from the package installed 🤔
vrialland
force-pushed
the
feat/terminal-api
branch
from
bc2135e to
ebce19a
Compare
vrialland
requested review from
Aleffio,
AlexandrosMor,
acampos1916,
martinsrenato and
rikterbeek
as code owners
|
Thanks for your contributions @vrialland |
|
Hello, any update on this PR? 🙏 |
vrialland
force-pushed
the
feat/terminal-api
branch
from
ebce19a to
4fcd02a
Compare
|
Hey @acampos1916, @Aleffio, @AlexandrosMor, @martinsrenato, @rikterbeek, sorry to ping you all, but can I have an update on this PR? This is a feature we need for one of our current development 🙏 |
|
Apologies for the delay @vrialland, LGTM! |
acampos1916
previously approved these changes
Nov 9, 2021
Alex-Pascal
previously approved these changes
Nov 29, 2021
jillingk
approved these changes
Jul 6, 2022
acampos1916
approved these changes
Jul 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of the POS terminal management API (https://docs.adyen.com/api-explorer/#/postfmapi/v1/overview)
Tested scenarios
All methods from the API have been tested with mocks as it was done for the other endpoints:
/assignTerminals/findTerminal/getStoresUnderAccount/getTerminalDetails/getTerminalsUnderAccountAll example JSON data was taken from the API explorer test requests