PW-6762: Fix HMAC verification functions corrupt notification item payload

[alainburindi]

Description
Do a copy of the payload to avoid changing the main notification payload
Tested scenarios

Fixed issue: #148

[acampos1916]

Thanks for this contribution @alainburindi. I believe this would break usages of those functions that for some reason are expecting the passed payload to change, right?

[alainburindi]

Thanks for this contribution @alainburindi. I believe this would break usages of those functions that for some reason are expecting the passed payload to change, right?

Yes, in case there are any. In our use case, we don't want the payload to be changed because our ERP uses one endpoint for different accounts.

We can add another parameter on the function that will be used to check whether the user wants the payloads to be changed or not.

def is_valid_hmac(dict_object, hmac_key, keep_additional_data=False):
    if keep_additional_data:
        dict_object = dict_object.copy()
# ...rest

@acampos1916 What do you think? with this, we won't break any existing usages that expect the payload to change

[acampos1916]

I like that @alainburindi

What do you think @AlexandrosMor?

[AlexandrosMor]

@alainburindi, Thank you for opening this pull request. yes indeed I prefer also that solution

[alainburindi]

@acampos1916 @AlexandrosMor I have done the changes accordingly

[AlexandrosMor]

Suggested change

	def is_valid_hmac(dict_object, hmac_key, keep_additional_data=False):
	if keep_additional_data:
	dict_object = dict_object.copy()
	def is_valid_hmac(dict_object, hmac_key):
	dict_object = dict_object.copy()

We decided to always keep the origin additional data. Could you please review it and add this suggestion ? @alainburindi

[alainburindi]

@AlexandrosMor I just modified the changes accordingly. can you check them?