Add Modifications to Python Library For Checkout Api #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
security code-scanning
… calling the correct action, cancels action fixed
eraserhead0705
requested review from
AlexandrosMor,
acampos1916,
martinsrenato and
rikterbeek
as code owners
acampos1916
reviewed
Mar 10, 2022
|
@acampos1916 gtg |
eraserhead0705
changed the title
|
@acampos1916 Any update from your side :) ? |
|
Any idea when this will be looked at? @acampos1916 @candemiralp @AlexandrosMor @martinsrenato @rikterbeek 😄 |
acampos1916
approved these changes
Jun 13, 2022
AlexandrosMor
approved these changes
Jun 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem you’re solving:
The Adyen Python Library lacks support for the full Checkout API actions.
Capture
Refund
Reversals
Cancel/Technical Cancel
Our Team at Tier needs this functionality implemented in the Python library in order to fully integrate with our backend system.
Your approach to fixing the problem:
Implemented the above functionality by building on the current service/client in the code base. I added a new parameter to send a path parameter to the Adyen Api.
Any tests you wrote:
Each new action has two tests written, one success and one that mocks an error.
Additionally a test that checks for race condition.