Skip to content

Conversation

jillingk
Copy link
Contributor

@jillingk jillingk commented Jul 7, 2022

Description
Created new CI pipeline with Tox to run the unittests on push and pull. Didn't add support for python 2.7 since that will be deprecated.

@wboereboom
Copy link
Contributor

Could you please remove Python 2.7 from the README as well if it's deprecated

@michaelpaul
Copy link
Contributor

Could you please remove Python 2.7 from the README as well if it's deprecated

@wboereboom I've suggested to deprecate Python 2.7. I think we should communicate that to merchants first and actually drop it on a next major release of the library.

@wboereboom
Copy link
Contributor

@michaelpaul in that case let's just state now that it's end of support and it will no longer be maintained. Does that still warrant a major update?

jillingk and others added 5 commits July 12, 2022 09:19
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
@michaelpaul
Copy link
Contributor

@michaelpaul in that case let's just state now that it's end of support and it will no longer be maintained. Does that still warrant a major update?

Yep, if a merchant application is still on Python 2, migrating to 3 could be a lot of work. Merchants don't expect to do such effort with minor/patch upgrades of the library.

@jillingk Can you please update the README.md about this:

  • Python 2.7 (Deprecated) or 3.6

jillingk and others added 3 commits July 12, 2022 10:35
@jillingk jillingk changed the title PW-6793 [PW-6793] Add new CI and update tests Jul 12, 2022
@jillingk jillingk merged commit 81839c0 into develop Jul 12, 2022
@michaelpaul michaelpaul mentioned this pull request Jul 13, 2022
@antolo-arch antolo-arch deleted the newCI branch January 17, 2023 15:12
@antolo-arch antolo-arch restored the newCI branch January 17, 2023 15:12
@antolo-arch antolo-arch deleted the newCI branch January 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants