PSP Reference header fix #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, take the PSP Reference from the header instead
rutgervandriel
requested review from
AlexandrosMor,
acampos1916,
antolo-arch,
candemiralp,
jillingk,
michaelpaul and
rikterbeek
as code owners
michaelpaul
previously approved these changes
Nov 29, 2022
antolo-arch
approved these changes
Nov 30, 2022
AlexandrosMor
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
_get_pspmethod only uses the PSP Reference from the headers if the variablepsp_referenceis equal to empty string. The problem is that when calls are made which do not return any PSP Reference in the fields, this check fails, as variablepsp_referenceis set to None. I outlined more of this problem in the following issue: #177We specifically ran into this issue because when we create a new Payment Session, we don't obtain the original PSP reference (as it is not part of the response data) and therefore cannot initiate a refund as we require the original PSP reference. This solution will fix this by obtaining the PSP Reference from the header.
Tested scenarios
Existing unit tests pass