[PW 7574] Make http client more generic #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
application info not mentioned in the docs, will not be submitted from the library
antolo-arch
requested review from
AlexandrosMor,
acampos1916,
candemiralp,
jillingk,
michaelpaul and
rikterbeek
as code owners
AlexandrosMor
previously approved these changes
Dec 20, 2022
michaelpaul
reviewed
Dec 22, 2022
Co-authored-by: Michael Paul <michael@michaelpaul.com.br>
reuse endpoints, delete not used endpoints in the settings, move the None check to determine base url and version
changed the live prefix check
jillingk
approved these changes
Jan 5, 2023
michaelpaul
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed functions to be more generic to support openAPI generation in the future, refactored the http client
Tested scenarios
Unit tests
Fixed issue: