[PW-7552] Remove unnecessary escape_val #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antolo-arch
requested review from
AlexandrosMor,
acampos1916,
candemiralp,
jillingk,
michaelpaul,
rikterbeek and
wboereboom
as code owners
wboereboom
previously approved these changes
Jan 10, 2023
wboereboom
approved these changes
Jan 10, 2023
michaelpaul
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The escape_val function in the generate_notification_signature was indeed redundant and was causing wrong signatures to be generated if the request involved a slash.
Tested scenarios
Notification examples with slashes
Fixed issue: #160