[PW-7650] Refactor error handling #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the custom messages, now the error prints the response object, changed assertRaisesRegexp to assertRaisesRegexp as the prior is giving deprecation warnings. Added error code in the debug method in the exception class.
antolo-arch
requested review from
AlexandrosMor,
acampos1916,
candemiralp,
jillingk,
michaelpaul,
rikterbeek and
wboereboom
as code owners
wboereboom
reviewed
Jan 12, 2023
jillingk
approved these changes
Jan 16, 2023
AlexandrosMor
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the custom messages, now the error prints the response object, changed assertRaisesRegexp to assertRaisesRegexp as the prior is giving deprecation warnings. Added error code in the debug method in the exception class.
Tested scenarios
Errors raised by Checkout and Management API