Fix usage of xapikey in the kwargs of the methods #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antolo-arch
requested review from
acampos1916,
candemiralp and
rikterbeek
as code owners
jillingk
previously approved these changes
Mar 29, 2023
jillingk
approved these changes
Mar 29, 2023
michaelpaul
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned here #233 when passing the xapikey in the method, there are two xapikeys that end up in the http client. By modifying the kwargs and returning it in the set_credenetials function only one is passed further.
Tested scenarios
Added a unit test in checkout
Fixed issue: