-
Notifications
You must be signed in to change notification settings - Fork 47
Fix(generator): Correct method signatures and refactor services #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR refactors the service layer to improve modularity, corrects method signatures, and updates several APIs. The changes include moving services to dedicated directories, fixing incorrect method signatures in the generated service methods, and updating test files to align with the new service structure. The review focuses on ensuring the correctness of the changes, particularly the method signature corrections and the new service structure.
Adyen/services/balancePlatform/transfer_limits_balance_platform_level_api.py
Show resolved
Hide resolved
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, all looking mostly good.
There are few minor comments and the SessionAuthentication URL fix.
Adyen/services/balancePlatform/transfer_limits_balance_account_level_api.py
Show resolved
Hide resolved
|



This PR introduces a significant refactoring of the service layer to improve modularity and corrects auto-generated method signatures that were previously incorrect.
Description
The template was incorrectly including the required request body params as a separate, unused argument in the generated service methods.
The template has been corrected to only include required
pathParamsin the method signature alongside therequestobject, which holds the body. This fixes incorrect method signatures across multiple services.In addition to this correction, this PR includes a broader restructuring of the service modules and several API updates.
Key Changes:
Method Signature Correction:
api.mustachetemplate to prevent duplicating the request body fields in method signatures.Service Module Refactoring:
Adyen/services/balanceControl/).balanceControl,binlookup,dataProtection,disputes,posMobile,recurring, andstoredValue.API Updates:
TransferLimitsBalanceAccountLevelApiandTransferLimitsBalancePlatformLevelApi.validate_shopper_idmethod to theUtilityApi.v3tov4.Test Updates: