Skip to content

Conversation

@galesky-a
Copy link
Contributor

@galesky-a galesky-a commented Oct 27, 2025

This PR introduces a significant refactoring of the service layer to improve modularity and corrects auto-generated method signatures that were previously incorrect.

Description

The template was incorrectly including the required request body params as a separate, unused argument in the generated service methods.

The template has been corrected to only include required pathParams in the method signature alongside the request object, which holds the body. This fixes incorrect method signatures across multiple services.

In addition to this correction, this PR includes a broader restructuring of the service modules and several API updates.

Key Changes:

  • Method Signature Correction:

    • Fixed the api.mustache template to prevent duplicating the request body fields in method signatures.
    • Regenerated services to apply the corrected, cleaner method signatures.
  • Service Module Refactoring:

    • Each service now resides in its own dedicated directory (e.g., Adyen/services/balanceControl/).
    • This improves modularity and makes the codebase easier to navigate and maintain.
    • The following services have been restructured: balanceControl, binlookup, dataProtection, disputes, posMobile, recurring, and storedValue.
  • API Updates:

    • Balance Platform: Added the new TransferLimitsBalanceAccountLevelApi and TransferLimitsBalancePlatformLevelApi.
    • Checkout: Added the validate_shopper_id method to the UtilityApi.
    • Legal Entity Management: Upgraded the API version from v3 to v4.
    • Recurring: Removed "Deprecated" warnings from several method docstrings.
  • Test Updates:

    • All related test files have been updated to align with the new service structure and corrected method signatures.

@galesky-a galesky-a changed the title Feat/update open api generator Fix(generator): Correct method signatures and refactor services Oct 27, 2025
@galesky-a
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR refactors the service layer to improve modularity, corrects method signatures, and updates several APIs. The changes include moving services to dedicated directories, fixing incorrect method signatures in the generated service methods, and updating test files to align with the new service structure. The review focuses on ensuring the correctness of the changes, particularly the method signature corrections and the new service structure.

@gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@galesky-a galesky-a marked this pull request as ready for review October 29, 2025 09:01
@galesky-a galesky-a requested review from a team as code owners October 29, 2025 09:01
@galesky-a galesky-a requested a review from gcatanese October 29, 2025 09:01
Copy link
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, all looking mostly good.
There are few minor comments and the SessionAuthentication URL fix.

@sonarqubecloud
Copy link

@gcatanese gcatanese merged commit 09bc1ce into main Oct 30, 2025
7 checks passed
@gcatanese gcatanese deleted the feat/update-open-api-generator branch October 30, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants