New release 1.3.0 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GitHub templates for issues and PRs
- Refactored code - Added pycodestyle to the Travis "script" to check for PEP8 compliance - Added pylint to the Travis "after_success" to get a score for general code cleaning
* Add support for third party payouts * Fix PEP-8 fixes * Remove bank details from payout validation If card details are provided, bank details are no longer mandatory. * Remove trailing comma (style fix) * Handle validation error with status code 500 * Billing address is not mandatory for storeDetailAndSubmitThirdParty * Add test cases for all payout actions * Fix wrong indentation * Use assertRaisesRegexp to be backward compat with Python 2.7 * check required fields recursively
Raise error on KeyError
Improvements
* deleted unused, rephrased somethin * style * regex must be raw string * Turned back to BytesIO
rikterbeek
requested review from
Aleffio,
AlexandrosMor,
cyattilakiss,
lancergr,
maassenbas and
rkewlani
Aleffio
approved these changes
Nov 13, 2018
rkewlani
reviewed
Nov 13, 2018
rkewlani
approved these changes
Nov 15, 2018
lancergr
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested scenarios
Fixed issue: