Skip to content

PW-781: Code optimizations #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Add service generation workflow
merged 3 commits into from
Nov 26, 2018
Merged

PW-781: Code optimizations #53

merged 3 commits into from
Nov 26, 2018

Conversation

@Aleffio
Copy link
Contributor

@Aleffio Aleffio commented Nov 21, 2018

Description

  • Raise an exception if response contains errorCode
  • Removed redundant status_code 422,
  • Always return an error_code along with a message in AdyenExceptions

Fixed issue: closes #47, closes #48, closes #49

@Aleffio
PW-781: Code optimizations: raise an exception if response contains e…
26318de 
…rrorCode, removed redundant status_code 422, always return an error_code along with a message in AdyenExceptions

closes #47, closes #48, closes #49
@Aleffio
pycodestyle fix
9181964
@Aleffio
pycodestyle fix
aaeb016
@coveralls
Copy link

coveralls commented Nov 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 38.409% when pulling aaeb016 on PW-781 into 1dcbde4 on develop.

@Aleffio Aleffio merged commit 72c24d8 into develop Nov 26, 2018
@AlexandrosMor AlexandrosMor deleted the PW-781 branch February 14, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rikterbeek rikterbeek Awaiting requested review from rikterbeek

@AlexandrosMor AlexandrosMor Awaiting requested review from AlexandrosMor

@lancergr lancergr Awaiting requested review from lancergr

@maassenbas maassenbas Awaiting requested review from maassenbas

2 more reviewers

@rkewlani rkewlani rkewlani approved these changes

@cyattilakiss cyattilakiss cyattilakiss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Method _handle_response returns multiple object types Allow customer handle error codes This line will never fire

4 participants

@Aleffio @coveralls @rkewlani @cyattilakiss