Feature/checkoutv40 #56

AlexandrosMor · 2019-01-08T16:24:49Z

Description

Tested scenarios

Fixed issue:

coveralls · 2019-01-08T16:30:54Z

Coverage increased (+2.4%) to 39.319% when pulling a66d3cc on feature/checkoutv40 into 72c24d8 on develop.

Aleffio · 2019-01-09T08:32:26Z

Adyen/client.py

+            service (str): API service to place request through.
+            action (str): the API action to perform.
+        """
+        if action == "paymentDetails":


Suggested change

if action == "paymentDetails":

if action == "paymentsDetails":

Aleffio · 2019-01-09T08:32:31Z

Adyen/client.py

+            action (str): the API action to perform.
+        """
+        if action == "paymentDetails":
+            action = "payment/details"


Suggested change

action = "payment/details"

action = "payments/details"

Aleffio · 2019-01-09T08:35:52Z

Adyen/client.py

+        """
+        if action == "paymentDetails":
+            action = "payment/details"
+        if action == "paymentResult":


Suggested change

if action == "paymentResult":

if action == "paymentsResult":

Aleffio · 2019-01-09T08:36:02Z

Adyen/client.py

+        if action == "paymentDetails":
+            action = "payment/details"
+        if action == "paymentResult":
+            action = "payment/result"


Suggested change

action = "payment/result"

action = "payments/result"

Aleffio · 2019-01-09T08:36:31Z

Adyen/client.py

+            action = "payment/details"
+        if action == "paymentResult":
+            action = "payment/result"
+        if action == "originKey":


Suggested change

if action == "originKey":

if action == "originKeys":

Aleffio · 2019-01-09T08:41:24Z

Adyen/client.py

+            action = "v1/originKeys"
+
+        base_uri = settings.BASE_CHECKOUT_URL.format(platform)
+        api_version = settings.CHECKOUT_API_VERSION


for checkoutUtility (originKeys) the versioning is different(v1 only at the moment),
I would put api_version at the beginning and replace it in case the action is originKeys

It is fixed now

Aleffio · 2019-01-09T08:44:55Z

Adyen/httpclient.py

            int:    HTTP status code, eg 200,404,401
            dict:   Key/Value pairs of the headers received.
-        """
+        """ % self.pr


Suggested change

""" % self.pr

"""

Aleffio · 2019-01-09T08:45:07Z

Adyen/httpclient.py

+                       xapikey="",
                       headers=None,
                       timeout=30):
+        self.pr = """pr"""


Suggested change

self.pr = """pr"""

Aleffio · 2019-01-09T08:49:56Z

Adyen/services.py

+                                                 action, **kwargs)
+
+    def payment_result(self, request="", **kwargs):
+        action = "paymentResult"


Suggested change

action = "paymentResult"

action = "paymentsResult"

Aleffio · 2019-01-09T08:50:23Z

Adyen/validation.py

+                             "channel", "returnUrl", "countryCode",
+                             "shopperLocale", "sessionValidity",
+                             "merchantAccount"]
+actions['paymentResult'] = ["payload"]


Suggested change

actions['paymentResult'] = ["payload"]

actions['paymentsResult'] = ["payload"]

rikterbeek · 2019-01-09T12:57:05Z

Adyen/settings.py

+ENDPOINT_PROTOCOL = "https://"
+BASE_CHECKOUT_URL = "https://checkout-{}.adyen.com"
+CHECKOUT_URL_LIVE_SUFFIX = "-checkout-live.adyenpayments.com/checkout"
+CHECKOUT_API_VERSION = "v40"


these 4 static variables looks very similar and a bit difficult to understand. Would it be an idea to keep it easy like:
const ENDPOINT_PROTOCOL = "https://";
ENDPOINT_CHECKOUT_TEST = "https://checkout-test.adyen.com/checkout";
ENDPOINT_CHECKOUT_LIVE_SUFFIX = "-checkout-live.adyenpayments.com/checkout";
like we do in php ?

rikterbeek · 2019-01-09T13:00:08Z

Adyen/client.py

        self.username = username
        self.password = password
+        self.xapikey = xapikey
        self.review_payout_username = review_payout_username


should we not add live_endpoint_prefix as property ?

rikterbeek · 2019-01-09T13:00:31Z

Adyen/httpclient.py

        """This function will POST to the url endpoint using requests.
        Returning an AdyenResult object on 200 HTTP response.
-        Either json or data has to be provided.
+        Either json or data has to be %sovided.


what is %sovided ?

cyattilakiss · 2019-01-09T13:08:19Z

Adyen/client.py

+            # xapikey at self object has highest priority.
+            # fallback to root module
+            # and ensure that it is set.
+            if self.xapikey:


the api key can become the first to check and use instead of the username password, since all our APIs are working fine with the API key only.

cyattilakiss · 2019-01-09T13:09:43Z

Adyen/httpclient.py


        # Adding basic auth if username and password provided.
        auth = None
        if username and password:


Also here the api key can be the default and not the fallback plan

I am not sure what you mean default. Do you suggest to remove basic authentication? If the xapi become first then it is default, correct?

I agree with Attilla ApiKey has preference over username and password.

It is fixed by adding the xapikey in high priority

rikterbeek · 2019-01-15T13:37:42Z

Adyen/settings.py

 BASE_PAL_URL = "https://pal-{}.adyen.com/pal/servlet"
 BASE_HPP_URL = "https://{}.adyen.com/hpp"
-API_VERSION = "v30"
+ENDPOINT_LIVE_SUFFIX = "-pal-live.adyenpayments.com"


is this being used ?

correct, it is not used so it can be removed

cyattilakiss · 2019-01-15T14:48:45Z

Adyen/settings.py


 BASE_PAL_URL = "https://pal-{}.adyen.com/pal/servlet"
 BASE_HPP_URL = "https://{}.adyen.com/hpp"
-API_VERSION = "v30"


Depricate the API_VERSION instead of removing it to follow semver

…SION

AlexandrosMor added 13 commits January 3, 2019 16:59

Add payment methods with mock test

26cccd9

Format lines

e6986a7

Format lines for client

40b60b0

Format lines for client long lines

2e834fb

Format lines for checkout

25ca3f2

Format lines for checkout again

bee6945

Add all checkout components

1b50cad

format test lines

b515f7c

Add checkout test cases for errors

a2bfc2c

Fixes with e2e test

22fb285

Fixes comment length

247cbaa

remove white space

1ca76fb

correct checkout utility

8c257eb

AlexandrosMor assigned Aleffio, rikterbeek, rkewlani, cyattilakiss and maassenbas Jan 8, 2019

AlexandrosMor requested review from Aleffio, cyattilakiss, maassenbas, rikterbeek and rkewlani January 9, 2019 08:46

AlexandrosMor assigned AlexandrosMor and unassigned Aleffio, rikterbeek, rkewlani, maassenbas and cyattilakiss Jan 9, 2019

Aleffio reviewed Jan 9, 2019

View reviewed changes

AlexandrosMor added 6 commits January 9, 2019 10:39

add custom endpoint

236cd10

Remove white space in unit test

4782cb6

Add checkout utility url

0a134fa

rename to payments details

2421b54

remove unused code

5e7d9c3

add utility api version

f3627f7

rikterbeek reviewed Jan 9, 2019

View reviewed changes

cyattilakiss reviewed Jan 9, 2019

View reviewed changes

AlexandrosMor added 2 commits January 10, 2019 13:35

Improve settings and client

c397486

Correct checkout url payments result

4467940

Aleffio approved these changes Jan 10, 2019

View reviewed changes

cyattilakiss approved these changes Jan 10, 2019

View reviewed changes

AlexandrosMor added 2 commits January 15, 2019 12:44

imporove determine checkout url

0aa55af

fix determine checkout url

a13dc7e

rikterbeek reviewed Jan 15, 2019

View reviewed changes

remove ENDPOINT_LIVE_SUFFIX for pal

25afd0c

cyattilakiss reviewed Jan 15, 2019

View reviewed changes

AlexandrosMor added 4 commits January 15, 2019 17:05

Deprecate API_VERSION

768c84b

Intoduce API_PAYMENT_VERSION and API_PAYOUT_VERSION deprecate API_VER…

42cb7e4

…SION

Remove API_VERSION

ec4f563

UpdateAPI_PAYMENT_VERSION = v40

a66d3cc

rikterbeek approved these changes Jan 16, 2019

View reviewed changes

AlexandrosMor merged commit 1d94500 into develop Jan 16, 2019

AlexandrosMor deleted the feature/checkoutv40 branch February 14, 2019 13:32

	if action == "paymentDetails":
	if action == "paymentsDetails":

	actions['paymentResult'] = ["payload"]
	actions['paymentsResult'] = ["payload"]

Feature/checkoutv40 #56

Feature/checkoutv40 #56

Uh oh!

Conversation

AlexandrosMor commented Jan 8, 2019

Uh oh!

coveralls commented Jan 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexandrosMor Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coveralls commented Jan 8, 2019 •

edited

Loading

AlexandrosMor Jan 10, 2019 •

edited

Loading