fix adapter options for faraday 1.x, fixes #177 #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpaul
previously approved these changes
Sep 26, 2023
wboereboom
previously approved these changes
Sep 26, 2023
Contributor
|
@Aleffio its actually version 2.1 not 2.0 Faraday v2.1.0 https://github.com/lostisland/faraday/releases/tag/v2.1.0 Can you change the gem version comparison to that please? |
Contributor
Author
|
Hi @ollym , Best, Alessio |
antolo-arch
approved these changes
Oct 6, 2023
AlexandrosMor
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
quick fix for adapter options for Faraday 1.x
Tested scenarios
paymentMethods call with Faraday 1.10 and with Faraday 2.x
Fixed issue: #177