Code generation: update services and models #318
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the generated code based on recent modifications to the OpenAPI specification files. The primary impact is the expansion of the SDK's capabilities to include new endpoints and services for managing Strong Customer Authentication (SCA) associations and devices within the Balance Platform. This ensures the client library remains synchronized with the latest API features, enabling support for enhanced security measures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces two new API modules for SCA (Strong Customer Authentication) management within the BalancePlatform service: sca_association_management_api and sca_device_management_api. These modules are added to the balancePlatform.rb service definition and implemented in their respective files. The changes include requiring the new API files and defining the corresponding methods in the BalancePlatform class. The addition of these APIs enhances the platform's capabilities for managing SCA-related functionalities.
|
|
||
| def sca_association_management_api | ||
| @sca_association_management_api ||= Adyen::SCAAssociationManagementApi.new(@client, @version) | ||
| end | ||
|
|
||
| def sca_device_management_api | ||
| @sca_device_management_api ||= Adyen::SCADeviceManagementApi.new(@client, @version) | ||
| end |
There was a problem hiding this comment.
high: Consider grouping the sca related API definitions together for better readability and maintainability.
end
def platform_api
@platform_api ||= Adyen::PlatformApi.new(@client, @version)
end
def sca_association_management_api
@sca_association_management_api ||= Adyen::SCAAssociationManagementApi.new(@client, @version)
end
def sca_device_management_api
@sca_device_management_api ||= Adyen::SCADeviceManagementApi.new(@client, @version)
end| # NOTE: This class is auto generated by OpenAPI Generator | ||
| # Ref: https://openapi-generator.tech | ||
| # | ||
| # Do not edit the class manually. |
There was a problem hiding this comment.
medium: The comment suggests that the class is auto-generated and should not be edited manually. While this might be true, consider adding a brief description of the API's purpose to provide context for developers who might need to work with it. This is especially helpful if the auto-generation process doesn't include detailed documentation.
| # NOTE: This class is auto generated by OpenAPI Generator | ||
| # Ref: https://openapi-generator.tech | ||
| # | ||
| # Do not edit the class manually. |
There was a problem hiding this comment.
medium: The comment suggests that the class is auto-generated and should not be edited manually. While this might be true, consider adding a brief description of the API's purpose to provide context for developers who might need to work with it. This is especially helpful if the auto-generation process doesn't include detailed documentation.
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
46cd265 to
a147d09
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
a147d09 to
98660af
Compare
|
OpenAPI spec files or templates have been modified on 05-11-2025 by commit.