Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CSP error caused by regenerator-runtime #1528

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

m1aw
Copy link
Contributor

@m1aw m1aw commented Mar 8, 2022

Summary

We got a report from PayByLink that they where experiencing CSP errors. This was being caused by facebook/regenerator#450

This PR solves this issue by setting the regenerator-runtime to version ^0.13.9 across all packages. For this a resolutions is set on the global package.json because of a bug in yarn. When yarnpkg/yarn#5039 is fixed we can move this resolution inside lib workspace.

Tested scenarios

PayByLink tested this in their local setup

Fixed issue:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Size Change: +5 B (0%)

Total Size: 758 kB

Filename Size Change
packages/lib/dist/adyen.js 203 kB +11 B (0%)
packages/lib/dist/cjs/index.js 172 kB -2 B (0%)
packages/lib/dist/es.modern/index.js 89 kB -1 B (0%)
packages/lib/dist/es/index.js 103 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 4.48 kB
packages/lib/dist/es.modern/cs-CZ.js 4.01 kB
packages/lib/dist/es.modern/da-DK.js 3.64 kB
packages/lib/dist/es.modern/de-DE.js 3.93 kB
packages/lib/dist/es.modern/el-GR.js 4.95 kB
packages/lib/dist/es.modern/es-ES.js 3.67 kB
packages/lib/dist/es.modern/fi-FI.js 3.72 kB
packages/lib/dist/es.modern/fr-FR.js 3.87 kB
packages/lib/dist/es.modern/hr-HR.js 3.79 kB
packages/lib/dist/es.modern/hu-HU.js 3.97 kB
packages/lib/dist/es.modern/it-IT.js 3.68 kB
packages/lib/dist/es.modern/ja-JP.js 4.43 kB
packages/lib/dist/es.modern/ko-KR.js 4.04 kB
packages/lib/dist/es.modern/nl-NL.js 3.7 kB
packages/lib/dist/es.modern/no-NO.js 3.63 kB
packages/lib/dist/es.modern/pl-PL.js 4.06 kB
packages/lib/dist/es.modern/pt-BR.js 3.71 kB
packages/lib/dist/es.modern/ro-RO.js 3.92 kB
packages/lib/dist/es.modern/ru-RU.js 4.68 kB
packages/lib/dist/es.modern/sk-SK.js 4.05 kB
packages/lib/dist/es.modern/sl-SI.js 3.7 kB
packages/lib/dist/es.modern/sv-SE.js 3.66 kB
packages/lib/dist/es.modern/zh-CN.js 3.94 kB
packages/lib/dist/es.modern/zh-TW.js 4.11 kB
packages/lib/dist/es/ar.js 4.48 kB
packages/lib/dist/es/cs-CZ.js 4.01 kB
packages/lib/dist/es/da-DK.js 3.64 kB
packages/lib/dist/es/de-DE.js 3.93 kB
packages/lib/dist/es/el-GR.js 4.95 kB
packages/lib/dist/es/es-ES.js 3.67 kB
packages/lib/dist/es/fi-FI.js 3.72 kB
packages/lib/dist/es/fr-FR.js 3.87 kB
packages/lib/dist/es/hr-HR.js 3.79 kB
packages/lib/dist/es/hu-HU.js 3.97 kB
packages/lib/dist/es/it-IT.js 3.68 kB
packages/lib/dist/es/ja-JP.js 4.43 kB
packages/lib/dist/es/ko-KR.js 4.04 kB
packages/lib/dist/es/nl-NL.js 3.7 kB
packages/lib/dist/es/no-NO.js 3.63 kB
packages/lib/dist/es/pl-PL.js 4.06 kB
packages/lib/dist/es/pt-BR.js 3.71 kB
packages/lib/dist/es/ro-RO.js 3.92 kB
packages/lib/dist/es/ru-RU.js 4.68 kB
packages/lib/dist/es/sk-SK.js 4.05 kB
packages/lib/dist/es/sl-SI.js 3.7 kB
packages/lib/dist/es/sv-SE.js 3.66 kB
packages/lib/dist/es/zh-CN.js 3.94 kB
packages/lib/dist/es/zh-TW.js 4.11 kB

compressed-size-action

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@m1aw m1aw merged commit 25959b5 into master Mar 8, 2022
@m1aw m1aw deleted the fix/csp-error-regenerator-runtime branch March 8, 2022 16:23
@ribeiroguilherme ribeiroguilherme mentioned this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants