Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why change case of tags? #42

Closed
hankbeasley opened this issue May 16, 2018 · 3 comments
Closed

Why change case of tags? #42

hankbeasley opened this issue May 16, 2018 · 3 comments

Comments

@hankbeasley
Copy link

hankbeasley commented May 16, 2018

var header = char.ToUpper(series.Columns[col][0]) + series.Columns[col].Substring(1);

that line of code makes this library hard to deal with.

@mvadu
Copy link
Contributor

mvadu commented May 16, 2018

@hankbeasley It should have been removed when I open sourced my library. In my original use case I was doing this as "beautification" to show the header in camel case. Thanks for bringing this up. I will remove this in the next minor version release.

mvadu added a commit that referenced this issue Oct 10, 2018
@mvadu mvadu mentioned this issue Oct 10, 2018
@mvadu
Copy link
Contributor

mvadu commented Oct 11, 2018

@hankbeasley sorry, it took me quite a while to get back. One problem with not changing case is some of the properties like default are not valid in C# as property names, but Default is. With the usage of ExpandoObject these invalid property names become a problem (e.g. in the retention policy there is a field called default).

mvadu added a commit that referenced this issue Oct 11, 2018
mvadu added a commit that referenced this issue Oct 11, 2018
@mvadu
Copy link
Contributor

mvadu commented Oct 11, 2018

With #51, GetInfluxSeries has an optional parameter SafePropertyNames which is true by default but can be false to turn off these beautification.

@mvadu mvadu closed this as completed in #51 Oct 11, 2018
mvadu added a commit that referenced this issue Oct 11, 2018
Fix #42, #48 and #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants