Fix #82: QueryMultiSeriesAsync should return "partial" #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponses are truncated by InfluxDB
|
The checks are failing because InfluxDB needs a special configuration for a new test to succeed (or we could remove the test, but I think it would be better to explicitly test the new functionality). |
[skip ci]
…Result Support multi query with multi result
Added PostQuery.
* Added PostQuery. * Added constructor.
|
You seems to be busy coding.. Thank you for your contribution. I am stuck with work and personal stuff.. I will probably review this over weekend. |
|
Hi @mvadu sorry, we did not know that all the changes in our fork would be included in this PR, this was not our intention... I'll reopen another pull request. Please ignore this one and sorry for the circumstances... |
|
@tbraun-hk are you going submit the partial flag part of this PR? |
|
Hi @mvadu yes, you are right. Sorry for taking so long, I'll open another pull request in the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an attempt to implement #82
If InfluxDB is configured to have a "max-row-limit", then InfluxDB will return the flag "partial=true" to indicate that a response has been truncated due to the max-row-limit.
With this pull request, the "partial" flag is included in the IInfluxSeries and set according to the influx raw response.
A unit test that verifies the changes has been implemented, too. However, you need to have an InfluxDB system with max-row-limit set to 100.000 for this test to succeed.