-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to extract opaque bodies #121
Conversation
cca882d
to
8d828fb
Compare
This avoids the risk of spurious rebuilds due to environment changes.
8d828fb
to
1d9b7a0
Compare
1d9b7a0
to
8788fa7
Compare
This removes the known-panic special case since in most cases we can store panic output.
8788fa7
to
8bc972c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we can't always retrieve the bodies of the external functions makes the effects of this PR quite limited, unfortunately. I wonder how the Kani people do, as I thought Kani looked into the bodies of the external definitions (@zhassan-aws could you comment on that?).
This being said, all the improvements you added to the UI tests are good and most welcome.
We could pass This doesn't work for |
In Kani, we run the See this RFC and one of the PRs that implements it for more information. Feel free to reach out for further information. |
Thank you for these links! |
This is useful documentation, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: it indeed makes sense to do check once and for all in translate_body
whether we should extract the body or not.
With
--extract-opaque-bodies
, we now also extract foreign globals, methods, trait provided methods, and ADT definitions. This is limited by two things:This PR includes a few tests that fail because of other problems. Two of them are hax limitations that I'm ignoring until we're back on hax master. I opened issues for the other two: #123, #120.
The PR also includes many improvements to the ui tests that I needed along the way.
Fixes #114