-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge linear control-flow before reconstruction #346
Conversation
@@ -3,7 +3,7 @@ all: build | |||
|
|||
.PHONY: build | |||
build: format | |||
cargo build --release | |||
CARGO_PROFILE_RELEASE_DEBUG=true cargo build --release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a drive-by change that keeps more debuginfo in release mode, so that we get useful backtraces and flamegraphs. Otherwise a lot of info is lost and the flamegraphs are useless
There's too high a risk of breaking libcrux because eurydice relies on specific control-flow shapes to detect loops. I'll remove the last pass added in this PR and keep it for when libcrux is fixed. |
c700a5a
to
bd1fbaa
Compare
I guess we should open an issue for this, then? |
I mean, I've got the branch ready for whenever it's fixed, no need
yes |
As long as we don't forget it, I'm fine with that. |
This PR advances the Charon submodule commit from 2024-09-02 to 2024-11-04. The main changes are due to: - AeneasVerif/charon#346: This changed some terminators into statements. - AeneasVerif/charon#407: The removal of some dependence on rustc code in the Charon library. Towards: #3585 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
This PR does several cfg-related things:
goto
chains into a single block. This happens particularly in bodies with lots of function calls; this lightens the work for the control-flow reconstruction pass;These two transformations made the llbc output slightly worse, so this PR also adds a pass that improves the cfg.