Translate global body as a separate initializer function #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
const-initializers
branch
2 times, most recently
from
569db09 to
8eb4994
Compare
This was referenced Nov 18, 2024
sonmarcho
reviewed
Nov 18, 2024
Nadrieril
force-pushed
the
const-initializers
branch
from
8eb4994 to
70eac81
Compare
Nadrieril
force-pushed
the
const-initializers
branch
from
70eac81 to
2edc77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we represent globals: instead of carrying a body directly, we instead translate their body as a separate initializer function. The global itself only keeps the id of this function. This reduces duplication in many places.
We were already presenting the llbc in this way on the ocaml side, so this PR doesn't change the LLBC OCaml API; it does change the ULLBC OCaml API however.