Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some features #479

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Add some features #479

merged 6 commits into from
Nov 29, 2024

Conversation

sonmarcho
Copy link
Member

I need this for a PR on Aeneas' side

@sonmarcho sonmarcho marked this pull request as ready for review November 29, 2024 00:41
@sonmarcho
Copy link
Member Author

I had to introduce several auxiliary visitors for definitions like global_decl, trait_decl, etc. because of a limitation of the visitor library: we can't derive visitors for a group of definitions containing structures with fields which have the same name (for instance global_decl and trait_decl both have a field named def_id, and if we try to derive one visitor for both definitions at once, we get a type error).

@sonmarcho
Copy link
Member Author

Also, this PR introduces an LlbcAstUtils.iter_crate_with_span visitor which keeps track of the declaration id and of the last (most precise) encountered span when visiting declarations.

@sonmarcho sonmarcho merged commit fbbc7a9 into main Nov 29, 2024
3 of 5 checks passed
@sonmarcho sonmarcho deleted the son/features branch November 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants