Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with Terminal 0.3.0 #10

Closed
franziskuskiefer opened this issue Apr 30, 2024 · 4 comments
Closed

Build fails with Terminal 0.3.0 #10

franziskuskiefer opened this issue Apr 30, 2024 · 4 comments

Comments

@franziskuskiefer
Copy link
Collaborator

The build fails with

File "bin/main.ml", line 41, characters 23-36:
41 |   let terminal_width = Terminal.Size.(match get_dimensions () with Some d -> d.columns | None -> 80) in

when using the current version of Terminal (0.3.0). Downgrading to 0.2.2 solves the issue.
@msprotz
Copy link
Contributor

msprotz commented Apr 30, 2024

The error message is: Error: Unbound module Terminal.Size

@msprotz
Copy link
Contributor

msprotz commented Apr 30, 2024

craigfe/progress#42

@msprotz
Copy link
Contributor

msprotz commented Apr 30, 2024

Temporarily worked around in 94eb31d, let's see what upstream says. Thanks for the bug report.

@msprotz
Copy link
Contributor

msprotz commented May 31, 2024

I don't know how to set up the build so that dune refuses to proceed unless the correct terminal version is installed. @W95Psp? but at least if you opam upgrade terminal, then you should be good

@msprotz msprotz closed this as completed in 6e86974 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franziskuskiefer @msprotz