-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented API breakage from 0.2.2 to 0.3.0 #42
Comments
Really sorry, I didn't know this package was used (I thought only A solution which could satisfy you and continue to ensure this constraint would be to propose a new |
I think that'd be great! I don't know how I ended up using this package, perhaps I saw something called terminal on opam written by a trustworthy author and decided it was a fine dependency to take on? ;-) |
Oups my bad! I'll make a PR shortly with a new |
CHANGES: - Revert the `terminal` API and keep an "happy" path to get size of a tty and be compatible with MirageOS (@art-w, @msprotz, craigfe/progress#42, craigfe/progress#43) - Use a `float` instead of a `int` in `flow_meter per-second` (@mbarbin, craigfe/progress#23, craigfe/progress#27)
It works, thanks! |
029cbc0 removed the Size module from the .mli of Terminal.
I was previously relying on that functionality to not have to re-implement the terminal width detection logic myself.
Can you either re-instate the Size module within Terminal, or suggest a replacement? Thanks!
The text was updated successfully, but these errors were encountered: