fix: deal with undefined variables passed into query string and updat…

…e addattachmentonissue to take mime and filename
Aeolun · Jul 10, 2024 · 97fc03b · 97fc03b
1 parent 9256b93
commit 97fc03b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/test-and-release.yml b/.github/workflows/test-and-release.yml
@@ -8,14 +8,15 @@ jobs:
         node-version: ['18', '20', '22', 'lts/*', 'latest']
     steps:
       - uses: actions/checkout@v4
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
         with:
           version: latest
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'pnpm'
       - run: pnpm install
+      - run: pnpm run build
       - run: pnpm run test
       - run: pnpm run lint
   release:
@@ -36,7 +37,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: pnpm/action-setup@v2
+      - uses: pnpm/action-setup@v4
         with:
           version: latest
       - name: Setup Node.js

diff --git a/src/jira.test.ts b/src/jira.test.ts
@@ -75,21 +75,21 @@ describe("Jira API Tests", () => {
         strictSSL: false,
       });
 
-      expect(jira.httpsAgent.options.rejectUnauthorized).toBe(false);
+      expect(jira.httpsAgent?.options.rejectUnauthorized).toBe(false);
     });
 
     it("Constructor with ssl default empty", () => {
       const { jira } = createTestInstance({});
 
-      expect(jira.httpsAgent.options.rejectUnauthorized).toBe(true);
+      expect(jira.httpsAgent?.options.rejectUnauthorized).toBe(true);
     });
 
     it("Constructor with with ssl checking enabled", () => {
       const { jira } = createTestInstance({
         strictSSL: true,
       });
 
-      expect(jira.httpsAgent.options.rejectUnauthorized).toBe(true);
+      expect(jira.httpsAgent?.options.rejectUnauthorized).toBe(true);
     });
 
     it("should allow the user to pass in a certificate authority", () => {