Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added coordinates module, with tests #37

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aqreed
Copy link
Member

@aqreed aqreed commented Aug 26, 2019

added the following functions for coordinates transformation:

  • lla2ecef
  • ned2ecef
  • body2ned
  • ned2body
  • body2wind
  • wind2body

@aqreed
Copy link
Member Author

aqreed commented Sep 1, 2019

I have added the following function (with its tests):

  • ecef2ned

Also, improved tests for ned2body, body2ned, wind2body, body2wind and ned2ecef functions

@aqreed
Copy link
Member Author

aqreed commented Sep 5, 2019

Added the az_elev_dist function (with tests)

@aqreed
Copy link
Member Author

aqreed commented Mar 12, 2020

@jorgepiloto, I have updated this PR after #39. Builds are passing except TOXENV=check

@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #37 into master will increase coverage by 6.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   72.12%   78.30%   +6.18%     
==========================================
  Files          11       12       +1     
  Lines         330      424      +94     
==========================================
+ Hits          238      332      +94     
  Misses         92       92              
Impacted Files Coverage Δ
src/skaero/geometry/coordinates.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce6c86...7b9422b. Read the comment docs.

@aqreed
Copy link
Member Author

aqreed commented Mar 14, 2020

fixed this PR, all test ok. @jorgepiloto

@jorgepiloto
Copy link
Member

Thank you for the pull request @aqreed and sorry for this late answer. Could you please rebase this branch onto master branch so when merging the git history looks nice?

@aqreed aqreed changed the title added coordinates module, with tests. Updated setup to include it added coordinates module, with tests Mar 15, 2020
@aqreed
Copy link
Member Author

aqreed commented Mar 15, 2020

@jorgepiloto please tell me if everything is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants