Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all parts of a RMC sentence are parsed #60

Closed
3 tasks done
elpiel opened this issue Oct 10, 2022 · 1 comment
Closed
3 tasks done

Not all parts of a RMC sentence are parsed #60

elpiel opened this issue Oct 10, 2022 · 1 comment

Comments

@elpiel
Copy link
Member

elpiel commented Oct 10, 2022

After the fix in the documentation of RMC sentences #57 we've realized there are missing parts of the parsing of those sentences.

In particular the parsing of parts after the date is missing, i.e.:

Parsing that is missing

  1. Magnetic Variation, degrees
  2. E or W
  3. FAA mode indicator (NMEA 2.3 and later)
  4. Nav Status (NMEA 4.1 and later)
    A = autonomous, D = differential, E = Estimated,
    M = Manual input mode, N = not valid, S = Simulator, V = Valid

Testing

Make sure to test for all fields variations, more specifically 3 different versions of the sentence:

  • Pre- NMEA 2.3
  • NMEA 2.3 (with FAA mode)
  • NMEA 4.1 (with Nav status)
@elpiel elpiel added the Hacktoberfest Issues suitable for Hacktoberfest label Oct 10, 2022
@elpiel
Copy link
Member Author

elpiel commented Nov 18, 2022

Fixed in #66

@elpiel elpiel closed this as completed Nov 18, 2022
@elpiel elpiel removed the Hacktoberfest Issues suitable for Hacktoberfest label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant