Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Fix RMC docs #57

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Update/Fix RMC docs #57

merged 4 commits into from
Oct 10, 2022

Conversation

Turbo87
Copy link

@Turbo87 Turbo87 commented Oct 6, 2022

There was a broken link in the doc comment for the RmcData struct and while I was at it I also added some other missing information in the comment :)

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 76.80% // Head: 76.80% // No change to project coverage 👍

Coverage data is based on head (9970296) compared to base (a12f552).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          20       20           
  Lines         776      776           
=======================================
  Hits          596      596           
  Misses        180      180           
Impacted Files Coverage Δ
src/sentences/rmc.rs 89.28% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elpiel
Copy link
Member

elpiel commented Oct 10, 2022

Great catch and thank you for contributing to the project again!
I don't think we support all the options though... This is something you can improve on for this sentence.

If you're interested I've opened #60 issue for the additional parsing

@elpiel elpiel added the Hacktoberfest Issues suitable for Hacktoberfest label Oct 10, 2022
@elpiel elpiel merged commit 03695a6 into AeroRust:main Oct 10, 2022
@elpiel elpiel added hacktoberfest-accpeted Hacktoberfest accepted PR and removed Hacktoberfest Issues suitable for Hacktoberfest labels Oct 20, 2022
@elpiel elpiel linked an issue Oct 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accpeted Hacktoberfest accepted PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting additional sentences
2 participants