-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GST sentence parser #121
Conversation
"GST" feature is also added to the "GNSS" features package. Signed-off-by: zhrbrk <zberokh@gmail.com> <zahara.berokhrokh@exail.com>
Signed-off-by: zhrbrk <zberokh@gmail.com> <zahara.berokhrokh@exail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR!
I have a few comments on the doc comments.
Can you also make sure you use ///
doc comments instead of regular //
comments for the struct?
I will give it a more thorough look sometime later this week, in the meantime I will run the CI.
src/sentences/gst.rs
Outdated
// 1 2 3 4 5 6 7 8 9 | ||
// | | | | | | | | | | ||
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// 1 2 3 4 5 6 7 8 9 | |
// | | | | | | | | | | |
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF> | |
/// ```text | |
/// 1 2 3 4 5 6 7 8 9 | |
/// | | | | | | | | | | |
/// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF> | |
/// ``` |
src/sentences/gst.rs
Outdated
// | | | | | | | | | | ||
// $ --GST,hhmmss.ss,x,x,x,x,x,x,x*hh<CR><LF> | ||
// | ||
// Example: $GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Example: $GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54 | |
/// Example: `$GPGST,182141.000,15.5,15.3,7.2,21.8,0.9,0.5,0.8*54` |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 77.62% 77.78% +0.16%
==========================================
Files 34 35 +1
Lines 1247 1274 +27
==========================================
+ Hits 968 991 +23
- Misses 279 283 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhrbrk <zberokh@gmail.com> <zahara.berokhrokh@exail.com>
#54 Add GST sentence parser with unit test.
GST is now a stand-alone feature, and also added into the GNSS features package.