Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTM sentence parse support #128

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Add TTM sentence parse support #128

merged 8 commits into from
Aug 14, 2024

Conversation

Tapped
Copy link
Contributor

@Tapped Tapped commented May 14, 2024

#54 Add TTM sentence parse support

TTM is a stand-alone feature, but part of a new feature called "radar", when other radar messages as TLL or TLB is introduced.

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Looks good to me!

Could you do 2 more things to complete it:

  1. Add the example sentence in the TtmData docs as Example (you can check some of the other sentences for this
  2. Add the example in the https://github.com/AeroRust/nmea/blob/main/tests/all_supported_messages.rs test

src/sentences/ttm.rs Outdated Show resolved Hide resolved
@Tapped
Copy link
Contributor Author

Tapped commented May 20, 2024

@elpiel Thank you, I fixed your suggestions!

@elpiel
Copy link
Member

elpiel commented Jun 30, 2024

@elpiel Thank you, I fixed your suggestions!

I'm not sure if you are aware but the CI fails.

@Tapped
Copy link
Contributor Author

Tapped commented Aug 12, 2024

@elpiel
Yeah I noticed, but the errors seems to be unrelated to this PR.

I suspect its caused by an update of clippy. I'll make a separate PR to fix those errors, that I assume fails on latest main as well.

See for example:
https://github.com/AeroRust/nmea/actions/runs/9164588924/job/25378071147?pr=128#step:5:65

@Tapped Tapped mentioned this pull request Aug 12, 2024
@Tapped
Copy link
Contributor Author

Tapped commented Aug 14, 2024

I'm not sure what to do with the codecov failing?

@elpiel elpiel merged commit 6d44b63 into AeroRust:main Aug 14, 2024
12 of 13 checks passed
@elpiel
Copy link
Member

elpiel commented Aug 14, 2024

Nothing, I will find some time to investigate it.

Thank you once again for your contributions and patience!

If you are looking for more fun on the nmea crate, there are a few key features that will make the crate very useful for embedded platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants