-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TTM sentence parse support #128
Conversation
It makes the property more self explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! Looks good to me!
Could you do 2 more things to complete it:
- Add the example sentence in the
TtmData
docs asExample
(you can check some of the other sentences for this - Add the example in the https://github.com/AeroRust/nmea/blob/main/tests/all_supported_messages.rs test
@elpiel Thank you, I fixed your suggestions! |
I'm not sure if you are aware but the CI fails. |
@elpiel I suspect its caused by an update of clippy. I'll make a separate PR to fix those errors, that I assume fails on latest main as well. See for example: |
I'm not sure what to do with the codecov failing? |
Nothing, I will find some time to investigate it. Thank you once again for your contributions and patience! If you are looking for more fun on the nmea crate, there are a few key features that will make the crate very useful for embedded platforms. |
#54 Add TTM sentence parse support
TTM is a stand-alone feature, but part of a new feature called "radar", when other radar messages as TLL or TLB is introduced.