Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZDA sentence parser #83

Merged
merged 8 commits into from
Mar 27, 2023
Merged

Add ZDA sentence parser #83

merged 8 commits into from
Mar 27, 2023

Conversation

ekuinox
Copy link

@ekuinox ekuinox commented Mar 12, 2023

#54 Implements parser for ZDA sentence.

Does NMEA::parse_for_fix need to support ZDA ? I've not implemented it yet. 🤔

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.99 🎉

Comparison is base (725394f) 79.24% compared to head (2ea3139) 80.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   79.24%   80.24%   +0.99%     
==========================================
  Files          27       28       +1     
  Lines        1012     1058      +46     
==========================================
+ Hits          802      849      +47     
+ Misses        210      209       -1     
Impacted Files Coverage Δ
src/lib.rs 0.00% <ø> (ø)
src/parser.rs 77.90% <0.00%> (+0.08%) ⬆️
src/sentences/mod.rs 0.00% <ø> (ø)
src/parse.rs 72.15% <100.00%> (+0.72%) ⬆️
src/sentences/zda.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekuinox ekuinox changed the title Add ZDA parser Add ZDA sentence parser Mar 12, 2023
@elpiel
Copy link
Member

elpiel commented Mar 27, 2023

Does NMEA::parse_for_fix need to support ZDA ? I've not implemented it yet. thinking

Yes, it would be nice (in a follow up PR)

Thank you for the PR 🚀

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elpiel elpiel merged commit fcbe1b0 into AeroRust:main Mar 27, 2023
@ekuinox ekuinox deleted the feature/zda-parser branch April 16, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants