-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZDA sentence parser #83
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 79.24% 80.24% +0.99%
==========================================
Files 27 28 +1
Lines 1012 1058 +46
==========================================
+ Hits 802 849 +47
+ Misses 210 209 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Yes, it would be nice (in a follow up PR) Thank you for the PR 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#54 Implements parser for ZDA sentence.
Does
NMEA::parse_for_fix
need to supportZDA
? I've not implemented it yet. 🤔