Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VHW sentence parser #84

Merged
merged 7 commits into from
Apr 10, 2023
Merged

Add VHW sentence parser #84

merged 7 commits into from
Apr 10, 2023

Conversation

ekuinox
Copy link

@ekuinox ekuinox commented Mar 14, 2023

#54 Implements parser for VHW sentence.

Different definitions seem to exist, but for the time being, the implementation follows gpsd.

[GLOBALSAT] describes a different format in which the first three fields are water-temperature measurements. It’s not clear which is correct.

From https://gpsd.gitlab.io/gpsd/NMEA.html#_vhw_water_speed_and_heading

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.33 🎉

Comparison is base (750e0a9) 80.39% compared to head (c0139e5) 80.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   80.39%   80.72%   +0.33%     
==========================================
  Files          29       30       +1     
  Lines        1076     1100      +24     
==========================================
+ Hits          865      888      +23     
- Misses        211      212       +1     
Impacted Files Coverage Δ
src/lib.rs 0.00% <ø> (ø)
src/parser.rs 77.30% <0.00%> (-0.30%) ⬇️
src/sentences/mod.rs 0.00% <ø> (ø)
src/parse.rs 71.95% <100.00%> (+0.70%) ⬆️
src/sentences/vhw.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekuinox ekuinox marked this pull request as ready for review March 15, 2023 11:40
@elpiel
Copy link
Member

elpiel commented Apr 10, 2023

Thank you for your PR!

@elpiel elpiel merged commit b203556 into AeroRust:main Apr 10, 2023
@ekuinox ekuinox deleted the feature/vhw-parser branch April 11, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants