for S3 contrib package move to boto3 #26
Merged
+374
−443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanxu00
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
sorry for the delay, took a bit to read through PR
lgtm - as I understand DTs will first be upgrading to this version as a part of Thor testing? if we can make sure that batch and DT owner oncalls are aware of this upgrade as they deploy it that would be appreciated
|
Thank you Alan! will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the s3 contrib package to boto3 - pulled from Spotify's current version of the library - luigi/luigi/contrib/s3.py at master · spotify/luigi