Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to add additional domains as disposable domains #31

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Support to add additional domains as disposable domains #31

merged 1 commit into from
Jul 13, 2021

Conversation

daisy1754
Copy link
Contributor

@daisy1754 daisy1754 commented Jul 12, 2021 •
edited by git-hulk
Loading

close #30

lryong
lryong approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@lryong lryong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lryong lryong requested review from git-hulk and chuan-T July 13, 2021 01:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1022718071

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 84.184%
Changes Missing Coverage Covered Lines Changed/Added Lines %
handler.go 1 3 33.33%
Totals Coverage Status
Change from base Build 960051350: -0.1%
Covered Lines: 495
Relevant Lines: 588
💛 - Coveralls

git-hulk
git-hulk approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the PR title should be Support to add additional domains as disposable domains

@git-hulk git-hulk changed the title Add AddDisposableDomains method #30 Support to add additional domains as disposable domains #30 Jul 13, 2021
@git-hulk git-hulk changed the title Support to add additional domains as disposable domains #30 Support to add additional domains as disposable domains Jul 13, 2021
@git-hulk git-hulk added the enhancement New feature or request label Jul 13, 2021
@git-hulk git-hulk merged commit c72795a into AfterShip:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuan-T chuan-T chuan-T approved these changes

@lryong lryong lryong approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add disposable domain via code?
5 participants
@daisy1754 @coveralls @git-hulk @lryong @chuan-T