Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs overhaul #226

Merged
merged 30 commits into from
May 28, 2024
Merged

Docs overhaul #226

merged 30 commits into from
May 28, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented May 25, 2024

Resolves ENG-411

Copy link

gitguardian bot commented May 25, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10824647 Triggered Generic High Entropy Secret e03df8e docs/mint.json View secret
10824647 Triggered Generic High Entropy Secret e937c85 docs/mint.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@HowieG HowieG enabled auto-merge (squash) May 25, 2024 02:00
docs/v1/concepts/host-env.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, can we please keep PRs much much smaller. Even though these changes are all in the same vein, the larger the PR, the more likely stuff gets messed up, confused or lost

@HowieG
Copy link
Contributor Author

HowieG commented May 28, 2024

@bboynton97 I needed to xlr8

@HowieG
Copy link
Contributor Author

HowieG commented May 28, 2024

@bboynton97 but forreal I did one big PR bc I think it would've taken 3x as long to make branches for each and not have them conflict etc and the corresponding dip in motivation. Felt lower risk than code changes

@HowieG
Copy link
Contributor Author

HowieG commented May 28, 2024

@bboynton97 otherwise yes I always try to keep my PRs modular

@HowieG HowieG merged commit cf67191 into main May 28, 2024
6 of 7 checks passed
@HowieG HowieG deleted the eng-411-docs-overhaul-2 branch May 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants