Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore partitions with access errors. #246

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mbarnathan
Copy link
Contributor

📥 Pull Request

📘 Description
host_env will gracefully handle disk errors now

🔄 Related Issue (if applicable)
#170

🎯 Goal
Regardless of the ability to skip this functionality through a parameter, AgentOps shouldn't fail on the presence of an inaccessible drive (e.g. a removeable drive or network share).

🧪 Testing
Added specific unit test for this functionality.

@areibman
Copy link
Contributor

Awesome, thanks @mbarnathan! Taking a look

Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we fixed this previously! Thanks for catching this and contributing!

@siyangqiu siyangqiu merged commit 267d0df into AgentOps-AI:main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants