-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: anthropic provider on raw message #507
Conversation
e926814
to
9f9f7f8
Compare
9f9f7f8
to
3b8242a
Compare
Maybe [bedrock,vertex] is not what we're looking for, but picking these for now as its what anthropic's computer vision demo uses
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Only static analysis checks are failing (black); free to merge afterwards Edit 17/11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to ask @the-praxs to double check this but looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes needed.
I would remove requirement for the Bedrock and Vertex clients. But we can add support for them in a different PR.
…rtion and verbosity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Review Summary
Purpose:
Enhance reliability and response handling logic in the
AnthropicProvider
class within theagentops/llms/anthropic.py
file.Key Changes:
import json
to the top. Improved response handling logic to correctly parse and log data forAPIResponse
andLegacyAPIResponse
types.Impact:
Improves the reliability of the
AnthropicProvider
class by ensuring correct parsing and logging of response data and enhancing the handling of different response structures.Original Description
No existing description found