-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly structure completions in Ollama provider #589
Conversation
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
WalkthroughFinal WalkthroughThe recent update in the Ollama provider focuses on refining the structure of completion objects. By initializing these objects with specific keys such as 'role', 'content', 'tool_calls', and 'function_call', the update ensures a consistent and error-free data structure. Additionally, minor logic adjustments enhance the robustness of appending content to these objects, improving overall code reliability. Changes
🔗 Related PRs
InstructionsEmoji Descriptions:
Interact with the Bot:
Execute a command using the format:
Available Commands:
Tips for Using @bot Effectively:
Need More Help?📚 Visit our documentation for detailed guides on using Entelligence.AI. |
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Co-Authored-By: Alex Reibman <meta.alex.r@gmail.com>
Good job Devin |
🔍 Review Summary
Purpose
Key Changes
Refactor
role
,content
,tool_calls
, andfunction_call
keys.self._safe_record()
consistently.Enhancement
Impact
Link to Devin run: https://app.devin.ai/sessions/cb30c1672fa04a8c8b721754f9fb3611