Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module logger instead of root logger #63

Conversation

joaonadkarni
Copy link
Contributor

Currently this package is logging to the root logger which makes it harder to manage its logging. For a more details on why the root logger should be avoided you can also check the reasons mentioned in the 1st point here

In this change I take the logging out of the root logger and have a logger for the module.

@joaonadkarni
Copy link
Contributor Author

@areibman when you have time looking for a review here

@areibman
Copy link
Contributor

Looks great-- thanks for waiting @joaonadkarni !

@areibman areibman merged commit 07e60b9 into AgentOps-AI:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants