Skip to content

Commit

Permalink
Rename do_reflect option to do-reflect
Browse files Browse the repository at this point in the history
We should use dashes instead of underscores in command line options.
This confirms with the [Gnu style guide](https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html)
  • Loading branch information
oshoma committed Nov 16, 2023
1 parent b34e838 commit 1386ce9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/sherpa_ai/config/task_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def from_config(cls, configs: List[str]) -> "AgentConfig":
help="site to be used for the Google search tool.",
)
parser.add_argument(
"--do_reflect",
"--do-reflect",
action="store_true",
help="enable performing the reflection step for each agent.",
)
Expand Down
2 changes: 1 addition & 1 deletion src/tests/unit_tests/config/test_task_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

def test_all_parameters_parse_successfully():
site = "https://www.google.com"
input_str = f"Test input. --verbose --gsite {site} --do_reflect"
input_str = f"Test input. --verbose --gsite {site} --do-reflect"

parsed, config = AgentConfig.from_input(input_str)

Expand Down

0 comments on commit 1386ce9

Please sign in to comment.