[BUG] Cannot set attribute in Pinecone Vector Store

[20001LastOrder]

Describe the bug
The vectorstore based on Pinecone will fail due to cannot set attribute error

To Reproduce
Steps to reproduce the behavior:

1. Add Pinecone related keys to the .env file
2. Run pytest in the src folder
3. Multiple tests will fail due to the following error

    def __init__(self, namespace, db, embeddings, text_key):
        self.db = db
        self.namespace = namespace
>       self.embeddings = embeddings
E       AttributeError: can't set attribute

sherpa_ai\connectors\vectorstores.py:24: AttributeError

Expected behavior
These tests should pass

Screenshots

Additional context
After a bit dig in, I found that LangChain updated their VectorStore API and now embedding is a property function as following

 @property
    def embeddings(self) -> Optional[Embeddings]:
        """Access the query embedding object if available."""
        logger.debug(
            f"{Embeddings.__name__} is not implemented for {self.__class__.__name__}"
        )
        return None

So we need to change our inheritance accordingly, maybe by overriding this function.

[oshoma]

OK. The bug and failing test are unrelated to this PR, then?

[20001LastOrder]

OK. The bug and failing test are unrelated to this PR, then?

Yes, and it will be solved separately.

[oshoma]

Ok great. The rest of my comments are about small things.

…

On Tue, Jan 9, 2024 at 4:42 PM Boqi (Percy) Chen ***@***.***> wrote: OK. The bug and failing test are unrelated to this PR, then? Yes, and it will be solved separately. — Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAKWTYW2GA23XJWVIWFLALYNW2UFAVCNFSM6AAAAABALM7ZZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTHA2DIMZXGE> . You are receiving this because you commented.Message ID: ***@***.***>