-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description about how to access configuration variable values #145
Conversation
Might be helpful for Sherpa newbies.
* Then, modify your configuration as needed. You can use the ``OS Module`` to set the configuration variables as below. Remember not to share your private keys with anyone else. | ||
:: | ||
|
||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part is already done in the config.py
file by the load_dotenv
function. Weren't you able to get the environment variables setup without manually setting them with the os module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I assume a user first needs to set environment variables? What if they did not? Users might also use Jupyter Notebook services like Google collab. We can also note to set env variables before running the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the user needs to create a file called .env
and add the environment variables there following the format in .env_sample
. Maybe we can make this more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for writing the clarification.
Might be helpful for Sherpa newbies.