Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description about how to access configuration variable values #145

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

Aminolroaya
Copy link
Contributor

Might be helpful for Sherpa newbies.

@amirfz amirfz requested a review from 20001LastOrder August 30, 2023 17:27
* Then, modify your configuration as needed. You can use the ``OS Module`` to set the configuration variables as below. Remember not to share your private keys with anyone else.
::

import os
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is already done in the config.py file by the load_dotenv function. Weren't you able to get the environment variables setup without manually setting them with the os module?

Copy link
Contributor Author

@Aminolroaya Aminolroaya Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I assume a user first needs to set environment variables? What if they did not? Users might also use Jupyter Notebook services like Google collab. We can also note to set env variables before running the app?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the user needs to create a file called .env and add the environment variables there following the format in .env_sample. Maybe we can make this more explicit

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for writing the clarification.

@20001LastOrder 20001LastOrder merged commit 4c14dac into Aggregate-Intellect:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants