Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation validation #241

Merged
merged 15 commits into from
Dec 7, 2023
Merged

Citation validation #241

merged 15 commits into from
Dec 7, 2023

Conversation

ChenKua
Copy link
Contributor

@ChenKua ChenKua commented Nov 29, 2023

Add a citation validation module

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm looking forward to the improved citation module! Please see the comments. Other than this, we can also create some unit tests to this functionality.

src/sherpa_ai/actions/__init__.py Outdated Show resolved Hide resolved
src/sherpa_ai/citation_validation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR, just a few small comments. See below.

src/sherpa_ai/actions/google_search.py Show resolved Hide resolved
src/sherpa_ai/agents/qa_agent.py Outdated Show resolved Hide resolved
src/sherpa_ai/agents/qa_agent.py Outdated Show resolved Hide resolved
src/tests/unit_tests/test_citation_validation.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Merging...

@20001LastOrder 20001LastOrder merged commit 328fbca into Aggregate-Intellect:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants